fix all jsonld examples #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
maxhbr
commented
May 3, 2024
| "element": [ | ||
| "https://some.namespace#SPDXRef-Package", | ||
| "https://some.namespace#File1", | ||
| "https://some.namespace#file1", | ||
| "https://some.namespace#file2", | ||
| "https://spdx.dev/elements/3F26391C#spdx-spec-v2.3", |
There was a problem hiding this comment.
the creator "https://spdx.dev/elements/3F26391C#spdx-spec-v2.3", is listed in "element" of the SpdxDocument but is not contained in the file
|
the "profileConformance" value "licensing" causes the parser to fail -> got dropped. |
|
The |
Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
|
There are now no examples demonstrating contentIdentifier, this should be added |
Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
|
Generated with https://github.com/maxhbr/spdx3ToGraph:
|
JPEWdev
approved these changes
May 3, 2024
Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current examples in serializaiton/json_ld/examples are all except one invalid.